-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] [FIX] Add method for crypto that are not in ISO4217 #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpcloureiro
suggested changes
Apr 20, 2022
gantunesr
changed the title
added func with cripto that are not in iso4217, iso used by FormatNumber
[FIX] Add method with crypto that are not in ISO4217
Apr 20, 2022
gantunesr
added
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
labels
Apr 20, 2022
jpcloureiro
approved these changes
Apr 20, 2022
Fatxx
added
Mobile QA board
and removed
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
labels
Apr 21, 2022
plasmacorral
added
QA in Progress
QA has started on the feature.
and removed
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
labels
Apr 27, 2022
…to fix/4107-currency-not-formatted
gantunesr
changed the title
[FIX] Add method with crypto that are not in ISO4217
[FIX] Add method for crypto that are not in ISO4217
Apr 28, 2022
mobularay
changed the title
[FIX] Add method for crypto that are not in ISO4217
[5.3] [FIX] Add method for crypto that are not in ISO4217
May 16, 2022
plasmacorral
added
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
and removed
QA in Progress
QA has started on the feature.
labels
May 31, 2022
mobularay
changed the title
[5.3] [FIX] Add method for crypto that are not in ISO4217
[5.4] [FIX] Add method for crypto that are not in ISO4217
Jun 7, 2022
plasmacorral
added
QA in Progress
QA has started on the feature.
and removed
QA in Progress
QA has started on the feature.
needs-qa
Any New Features that needs a full manual QA prior to being added to a release.
labels
Jun 7, 2022
tommasini
changed the title
[5.4] [FIX] Add method for crypto that are not in ISO4217
[5.3] [FIX] Add method for crypto that are not in ISO4217
Jun 9, 2022
mobularay
added
the
release-5.3.0
Issue or pull request that will be included in release 5.3.0
label
Jun 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
A successful QA run through has been done
release-5.3.0
Issue or pull request that will be included in release 5.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem was that if we have the currency conversion selected with one of the Crypto values options, some of them will break our app because they were not listed in the ISO4217 that it's the currency format followed by the FormatNumber
It was also opened a ticket here to try to understand why some crypto codes are acceptable and others not.
Proposed solution
The proposed solution it's when we the currency conversion selected do not meet the iso standards we return the format value currency for example "1 1ST"
Code Impact
Big code impact, the formatCurrency method is used in other files that are used in multiple components and that components are in major transactions screens / transactions modals.
Screenshots or Videos
https://recordit.co/ZG6nNRfvzB
Add relevant testing to ensure the bug is fixed
Test Cases
Case1:
Checklist
Issue
Progresses #4107