Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Undefined address error #4166

Merged
merged 5 commits into from
Apr 27, 2022
Merged

[FIX] Undefined address error #4166

merged 5 commits into from
Apr 27, 2022

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Apr 27, 2022 •
edited
Loading

Description

There's an edge case in the address util method formatAddress where an undefined value would get passed and try to call toLowerCase.

undefined is not an object (evaluating 'o.toLowerCase')

Reference: https://sentry.io/organizations/metamask/issues/3215676712/?project=2299799&query=is%3Aunresolved+undefined+is+not+an+object+%28evaluating+%27o.toLowerCase%27%29&statsPeriod=14d

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Progresses #???

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Apr 27, 2022
@gantunesr gantunesr requested a review from a team as a code owner April 27, 2022 04:57
tommasini
tommasini reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tommasini
tommasini approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sethkfman
sethkfman approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit 1d14435 into main Apr 27, 2022
@gantunesr gantunesr deleted the fix/undefined-address-crash branch April 27, 2022 21:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gantunesr @sethkfman @tommasini