[5.2][IMPROVEMENT] Adds support for 'dapp/' urls support on 'metamask://' and fixes DL opening to Apple Store #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreahaku
added
needs-qa
andreahaku
changed the title
andreahaku
added
Code Impact - Low
andrepimenta
removed
the
needs-dev-review
|
May I ask when do you plan to release this fix? This is blocking issue for our team :( |
Hi @dmitrymikheevappus, most likely with version 5.2.0 so probably in a couple of weeks. In the meantime did you see what I wrote here? |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
andreahaku
force-pushed
the
feature/dapp_url_metamask_scheme
branch
from
0b38660
to
2dfc94c
Compare
andreahaku
changed the title
andreahaku
added
Priority - High
andreahaku
changed the title
cortisiko
approved these changes
May 13, 2022
cortisiko
added
QA Passed
tommasini
added
the
release-5.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for 'dapp/' urls support on 'metamask://' scheme.
So that it'll be possible to use links like:
metamask://dapp/google.comand have the same results ofhttps://metamask.app.link/dapp/google.com.This is not a deep link so it won't check if the app is installed and if not, take the user to stores to download it.
This is only works if the app is already installed (otherwise the device doesn't know how to deal with
metamask://links.Reason to use this over Branch.io links is that it does not depend on it and so can overcome some of the limitations of them, like sometimes not opening when programmatically called from dapps (without a user click/tap).
It also fixes the issue related to deep links going to Apple store on iOS even if the app is installed.
Checklist
Issue
Progresses #3965