-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2][Fix] Favourites not showing when home button is pressed in browser tab menu #4175
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to check if the user is on the homepage before we inject the favourites otherwise we will inject them into all websites. Does it need to be on RPCMethods?
It should only inject on the "metamask dapps web app" since the event is triggered from there. Maybe not I just used the RpcMethod logic because we were already using it for other events but we can create a custom event for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS 15.0 Simulator = Pass
iOS 15.5 iPhone 12 = Pass
Android 10 Pixel 3 Simulator = Pass
Android 12 Samsung A42 = Pass
Browser Favorites
Tap Home button shows Favorites = Pass
New Browser Tab show Favorites = Pass
Delete Favorites = Pass
Description
Fix no favourites shown when "home" is pressed in the browser, scripts are now guaranteed to be present when the website is loaded.
This is blocked by MetaMask/dapps#122 and should be tested and merged together.
How to test
http://localhost:3000/
orhttp://${your-ip}:3000/
localhost:3000
or{your-ip}:3000
Checklist
Issue
Progresses #3331