Browser Dapp Showcase #423
Conversation
There was a problem hiding this comment.
@estebanmino this is 🔥🔥🔥🔥
Added a few minor comments and for the record, I'm still impressed by the fact that you started this morning...
| <ActionSheet | ||
| ref={this.createActionSheetRef} | ||
| title={strings('home_page.remove_bookmark_title')} | ||
| options={['Remove', 'Cancel']} |
| flexDirection: 'row' | ||
| }, | ||
| icon: { | ||
| height: 35, |
There was a problem hiding this comment.
Since this icons are bigger, I'd refactor the websiteIcon component to receive a prop size, and use it to build the url of faviconkit so they don't get scaled on high res screens
Should look something like this:
<WebsiteIcon url={'https://metamask.io'} size={PixelRatio.getPixelSizeForLayoutSize(35)} />
There was a problem hiding this comment.
nice! didn't know this
| onInitialUrlSubmit={this.onInitialUrlSubmit} | ||
| navigation={this.props.navigation} | ||
| /> | ||
| <HomePage goTo={this.go} onInitialUrlSubmit={this.onInitialUrlSubmit} navigation={this.props.navigation} /> |
There was a problem hiding this comment.
I prefer the way it looked before but if this was prettier's fault ignore this comment.
app/util/featured-dapp-list.js
Outdated
| @@ -0,0 +1,23 @@ | |||
| export default [ | |||
| { | |||
| url: 'https://dai.makerdao.com/', | |||
app/util/featured-dapp-list.js
Outdated
| description: 'Maker is comprised of a stablecoin, collateral loans, and decentralized governance.' | ||
| }, | ||
| { | ||
| url: 'https://peepeth.com/welcome', |
There was a problem hiding this comment.
I'd send it to here instead https://peepeth.com/_
| url: 'https://gitcoin.co/', | ||
| name: 'Gitcoin', | ||
| description: 'Gitcoin is the easiest way to leverage the open source community to incentivize or monetize work.' | ||
| } |
There was a problem hiding this comment.
I'd put as #2 or even #1 uniswap.exchange
Also somewhere in the list: https://mainnet.aragon.org/
locales/en.json
Outdated
| @@ -327,22 +327,29 @@ | |||
| "backup_alert_message": "Tap to save your seed phrase", | |||
| "bookmarks": "Bookmarks", | |||
| "no_bookmarks": "Your bookmarks will show up here", | |||
| "remove_bookmark_title": "Do you want to remove this bookmark?" | |||
| "remove_bookmark_title": "Do you want to remove this favorite site?" | |||
There was a problem hiding this comment.
"Do you want to remove this site from your favorites?"
|
@brunobar79 built this in android there were some bugs. Comments addressed.
|
* browser top done * tab bar and favorites working * remove bookmarks * featured dapps with basic styles * go to featured * favorites working fine * favorite item style * final styles * url autocomplete * locales * move components to UI * snapshots * rename compoennt * missin locale * clean after search * small comments * pixel ratio * fix android and empty favorites * more android fixes
Description
This PR implements Browser Dapp Showcase following https://www.figma.com/file/BDcfanN7wCZqbB446t8szhQy/MetaMask-Mobile?node-id=126%3A0, also adding url autocomplete to that view.
Checklist
Issue
Resolves #262