Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2.0][FIX] Alignment of check icon with option on select component #4363

Merged
merged 2 commits into from
May 23, 2022

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented May 18, 2022

Description
The check icon was not aligned with the option on the options list of the languages available.

Proposed Solution
Align the option with the check icon on the options list.
That component it's used on different settings screens:

  • General Settings
  • Settings & Privacy
  • Advanced

Code Impact
Very low, just a style adjustment

Test Cases
General Settings:

  • Currency Conversion

    • IOS - ✅
    • Android - ✅
  • Current Language

    • IOS - ✅
    • Android - ✅
  • Search Engine

    • IOS - ✅
    • Android - ✅

Security Settings:

  • Auto Lock
    • IOS - ✅
    • Android - ✅

Advanced Settings:

  • IPFS Gateway
    • IOS - ✅
    • Android - no options to select

Screenshots/Recordings
Android Screenshot of IPFS Gateway:
image

IOS Simulator solution demo:
https://recordit.co/NuGiBlYblQ

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses #https://github.com/MetaMask/mobile-planning/issues/277

@tommasini tommasini requested a review from a team as a code owner May 18, 2022 14:16
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title [5.2.0][Fix] Alignment of check icon with option on select component [5.2.0][FIX] Alignment of check icon with option on select component May 19, 2022
@gantunesr gantunesr merged commit 13ab998 into release/5.2.0 May 23, 2022
@gantunesr gantunesr deleted the fix/277-2-select-language-alignment branch May 23, 2022 21:38
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2022
@chrisleewilcox chrisleewilcox added the QA Passed A successful QA run through has been done label May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants