[5.2.0][FIX] Secret Recovery Phrase text alignment #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gantunesr
added
the
needs-qa
chrisleewilcox
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The text was not aligned in the Reveal Secret Recovery Phrase screen and some languages needed some changes in the translation file.
Proposed Solution
I have edited the language files (german, Spanish and French) to have the translations with the spaces missing and improved the RevealPrivateCredential component to align the text.
Code Impact
Very low, will only change the phrase on that screen.
Test Cases
Case1:
Repeated the case1 for:
Screenshots/Recordings
SS in english:
Checklist
Issue
Progresses #278