Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][5.2] Additional fix form M6 issue (multiple tabs opened with new dapp schema) #4396

Merged
merged 1 commit into from
May 25, 2022
Merged

[FIX][5.2] Additional fix form M6 issue (multiple tabs opened with new dapp schema) #4396

merged 1 commit into from
May 25, 2022

Conversation

andreahaku
Copy link
Member

Description

Additional fix that makes the metamask://dapp/ schema behave as if it's dapp:// schema that is already in production

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses #???

@andreahaku andreahaku requested a review from a team as a code owner May 25, 2022 13:38
@andreahaku andreahaku added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 25, 2022
@andreahaku andreahaku merged commit fc971dc into release/5.2.0 May 25, 2022
@andreahaku andreahaku deleted the fix/m6-additional-fix-dapp-schema-double-tab branch May 25, 2022 15:28
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2022
@plasmacorral plasmacorral added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreahaku @plasmacorral