-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor transaction component #4420
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
e8f554d
to
b070dd4
Compare
@cortisiko @chrisleewilcox FYI this doesn't need QA but wanted you to be aware |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ran detox automated test. All test pass except deeplink and contract-nickname test fail but those automation test need to be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT.
Description
Abstracts the gas polling logic from the transaction component.
Checklist
Screenshots/Recordings
If applicable, add screenshots or recordings to visualize the changes
Issue
Progresses #???