Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component/4221 icon #4499

Merged
merged 15 commits into from
Jun 23, 2022
Merged

Component/4221 icon #4499

merged 15 commits into from
Jun 23, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jun 14, 2022

Description

#4221

Smaller and default
image

Larger and colored
image

Storybook options
image

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Screenshots/Recordings

If applicable, add screenshots or recordings to visualize the changes

Issue

Progresses #???

@Cal-L Cal-L requested a review from a team as a code owner June 14, 2022 19:26
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/component-library/components/Icon/README.md Outdated Show resolved Hide resolved
app/component-library/hooks/useStyles.ts Show resolved Hide resolved
metro.config.js Show resolved Hide resolved
Copy link
Contributor

@jpcloureiro jpcloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 23, 2022
@Cal-L Cal-L merged commit 517fb0f into main Jun 23, 2022
@Cal-L Cal-L deleted the component/4221-icon branch June 23, 2022 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2022
@Cal-L Cal-L added release-5.4.0 Issue or pull request that will be included in release 5.4.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.4.0 Issue or pull request that will be included in release 5.4.0 labels Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-5.4.0 Issue or pull request that will be included in release 5.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants