-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Jazz icons constantly changing #4503
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ticket is 🌮 🌮
Things I tested:
- sending funds to an ENS address and non-ENS address
- sending NFTs to an ENS address and non-ENS address
- Verified that [IMPROVEMENT] Address Verification #4418 , [FIX] Confusables bug #4318, and Immediately resolves name as soon as I enter ".eth", but this excludes the ability to enter many names #2830 did not regress.
Description
The jazz icon on the Send To screen in the Send Flow was changing when we look for an ENS, because the Jazz Icon component https://www.npmjs.com/package/react-native-jazzicon, was receiving an ens name on the address prop instead of an eth address.
Proposed Solution
When we look for an ENS name, we resolve that ens name and send it to the Jazz Icon component. This way the Jazz Icon will no longer change.
Code Impact
The changes it was only on the level of the SendTo component, the impact of this code is low.
Checklist
Screenshots/Recordings
Issue:
https://user-images.githubusercontent.com/46944231/168823545-0ba7bc06-2334-48e1-9575-53bc60bc9902.mp4
Solution:
https://user-images.githubusercontent.com/46944231/168823730-1ca0ba3e-77ad-4c9d-b8e2-0565dba99f78.mp4
Test Cases
Case 1:
Issue
Progresses #4353