-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Android activity launch mode #4527
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scenarios I covered:
-
I tested using the hardware back button at various points in the app: Going through the swaps flow then tapping on the hardware back button until I get to the wallet view. When I got to the wallet view I hit the home button then reopened the app, and tested the hardware back button on the send flow, While on the browser view, the Settings view
-
I also tested using the in-app back button: tested this on the settings view, On the send flow, on the swaps flow
-
I tested logging out of the app, landing on the log-in view then tapping the hardware back button. I was not taken back to the wallet view
-
I tested deep links with the app closed and in the background. Wallet connect deep links as well.
I tested using the hardware back button as well as the in-app back button on the change password view. -
I made a couple of transactions.
this is 👍
Description
Updated the launch mode in Android
Checklist