-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component/4226 bottom sheet #4718
Conversation
…to component/4226-bottom-sheet
…to component/4226-bottom-sheet
…to component/4226-bottom-sheet
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…to component/4226-bottom-sheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left quite a few comments
app/component-library/components/BottomSheet/BottomSheet.constants.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/BottomSheet/BottomSheet.stories.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/BottomSheet/BottomSheet.types.ts
Outdated
Show resolved
Hide resolved
* Create sheet header component * Finish SheetHeader component * Clean up sheet header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is so clean it cleansed my soul 👏 🧼
Description
#4226
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist