-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PS] Componentize Cell #4083 #4756
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments!
app/component-library/components/CellContainerSelectOption/CellContainerSelectOption.tsx
Outdated
Show resolved
Hide resolved
app/component-library/components/CellContainerSelectOption/CellContainerSelectOption.types.ts
Outdated
Show resolved
Hide resolved
...ent-library/components/CellContainerSelectOption/CellContainerSelectOption.snapshot.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved comments
17e2a82
to
0bb47c2
Compare
356dace
to
cb65ae6
Compare
Description
#4083
Screenshots/Recordings
Cell Container Select Item
Cell Container MultiSelect Item
Cell
Issue
Progresses #???
Checklist