Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANALYTICS] Improve SRP reveal metrics #4798

Merged
merged 11 commits into from
Aug 16, 2022
Merged

[ANALYTICS] Improve SRP reveal metrics #4798

merged 11 commits into from
Aug 16, 2022

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Aug 4, 2022

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Pull request to improve the SRP reveal metrics.

Note: Some events are duplicated and require PM assessment.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

NA

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/336

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 4, 2022
@gantunesr gantunesr marked this pull request as ready for review August 4, 2022 02:16
@gantunesr gantunesr requested a review from a team as a code owner August 4, 2022 02:16
@gantunesr gantunesr marked this pull request as draft August 6, 2022 02:54
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 6, 2022
@gantunesr gantunesr marked this pull request as ready for review August 9, 2022 21:49
@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 9, 2022
@gantunesr gantunesr added the release-5.6.0 Issue or pull request that will be included in release 5.6.0 label Aug 9, 2022
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code/events look good. Not certain which events would be duplicated though 🤷

Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit 4360703 into main Aug 16, 2022
@gantunesr gantunesr deleted the analytics/srp-reveal branch August 16, 2022 01:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2022
@cortisiko cortisiko added release-5.7.0 Issue or pull request that will be included in release 5.7.0 and removed release-5.6.0 Issue or pull request that will be included in release 5.6.0 labels Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. release-5.7.0 Issue or pull request that will be included in release 5.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants