-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Reveal SRP or Private Key wrong password error #4799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there another issue where you can still hit return on the keyboard, which will prompt the hold to reveal modal even with an incorrect password?
Reference to where this is mentioned - #4781
In reference to #4799 (review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 🌮 🌮 🌮
To test follow the accepted behavior listed here
…to fix/reveal-credential-bug
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
While trying to reveal the SRP or Private Key, if the user enters the wrong password the app would still display the "Hold To Reveal" component.
2. What is the improvement/solution?
This PR validates the password before allowing the user to proceed.
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Screen.Recording.2022-08-04.at.11.49.13.mov
Issue
Progresses #4781
Checklist