-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix password not being set as authentication type for login metrics #4824
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Here is a video walking through all the authentication methods. The data doe snot instantly populate in mixpanel but you can see after a few refreshes it always shows the correct value. |
5e2ca4e
to
3c92771
Compare
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
Analytics.applyUserProperty(AUTHENTICATION_TYPE.PASSWORD);
inside theSecureKeychain.resetGenericPassword
methodIssue
Progresses #???
Checklist