Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new QA builds for both Android and iOS #4833

Merged
merged 60 commits into from
Sep 21, 2022
Merged

Implement new QA builds for both Android and iOS #4833

merged 60 commits into from
Sep 21, 2022

Conversation

Fatxx
Copy link
Contributor

@Fatxx Fatxx commented Aug 10, 2022 •
edited
Loading

Description

  • This PR implements new QA apps for both Android and iOS;
  • It adds three new workflows in Bitrise: build_android_qa, build_ios_qa and create_qa_builds;
  • It renames the previous release builds in Bitrise to: build_android_release, build_ios_release and create_release_builds;
  • "About MetaMask" screen shows the current branch where the build was triggered from in QA build;

Screenshots/Recordings
iOS:
Screen Shot 2022-08-10 at 22 51 05
Screen Shot 2022-08-10 at 22 52 40
Android:
Screen Shot 2022-08-10 at 23 35 11
Screen Shot 2022-08-10 at 23 34 57

Related documents

Notion Knowledge Share

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/344 and https://github.com/MetaMask/mobile-planning/issues/345

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Fatxx and others added 30 commits August 3, 2022 14:25
@Fatxx
WIP
eb19a83
@Fatxx
Fix pods for new target
5963aca
@Fatxx
Remove unused file
ba48910
@Fatxx
Remove unused files
194a66e
@Fatxx
Remove logs
f1cb272
@sethkfman
added provisioning profile
96f8eed
@Fatxx
Change workflow name
4e280eb
@Fatxx
Merge branch 'implement/new-ios-target' of https://github.com/MetaMas…
a8affa2 
…k/metamask-mobile into implement/new-ios-target
@Fatxx
Add icons
e11c2fa
@Fatxx
Fix plist and update icons
9734597
@tommasini
new variants, dev, qa, prod added
9cdabce
@tommasini
pre release bundle script
68626dd
@Fatxx
TRY AGAIN
bf7b257
@Fatxx
TRY
557c50e
@tommasini
update bitrise yml
f1228d7
@Fatxx
Test
c25fd3c
@Fatxx
TEST
faf3a4b
@Fatxx
TEST
7edf81e
@sethkfman
enabled certificate installer step
311df86
@Fatxx
Test
28a60e2
@Fatxx
Merge branch 'implement/new-ios-target' of https://github.com/MetaMas…
7383d2c 
…k/metamask-mobile into implement/new-ios-target
@Fatxx
Create specific iOSExport.plist
eeddc6a
@Fatxx
TEST
fb1f56c
@Fatxx
Fix yml
bcef0ac
@tommasini
test
b2707b7
@tommasini
bitrise yml updated
38c3bc7
@Fatxx
Fix sentry properties for QA build
84f6b9a
@tommasini
checksum update
2c026ab
@tommasini
bitrise update
f89e9ef
@tommasini
qa icon
1bb9b18
sethkfman
sethkfman reviewed Aug 18, 2022
View reviewed changes
bitrise.yml Outdated Show resolved Hide resolved
sethkfman
sethkfman reviewed Aug 18, 2022
View reviewed changes
bitrise.yml Outdated Show resolved Hide resolved
sethkfman
sethkfman reviewed Aug 18, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
sethkfman
sethkfman reviewed Aug 18, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
sethkfman
sethkfman reviewed Aug 18, 2022
View reviewed changes
scripts/build.sh Outdated Show resolved Hide resolved
sethkfman
sethkfman reviewed Aug 18, 2022
View reviewed changes
scripts/build.sh Outdated Show resolved Hide resolved
sethkfman
sethkfman reviewed Sep 7, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
sethkfman
sethkfman reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix on the build.sh but other than that it looks good.

tommasini and others added 2 commits September 8, 2022 09:28
@tommasini @sethkfman
Update package.json
5ab7417 
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
@tommasini
Qa debug script for ios and android
cbac33f
sethkfman
sethkfman approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 21, 2022
@gantunesr
Copy link
Member

Alt Text

@cortisiko cortisiko removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 21, 2022
@cortisiko cortisiko merged commit e0fc585 into main Sep 21, 2022
@cortisiko cortisiko deleted the implement/new-qa-build branch September 21, 2022 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
devtools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Fatxx @gantunesr @sethkfman @chrisleewilcox @cortisiko @plasmacorral @tommasini @Andepande