Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "@react-native-community/async-storage" for "@react-native-async-storage/async-storage" #4941

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

gantunesr
Copy link
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,

1. What is the reason for the change?
The module @react-native-community/async-storage is deprecated, it's necessary to replace it with @react-native-async-storage/async-storage.

Screen Shot 2022-09-05 at 16 33 00

NPM @react-native-community/async-storage

2. What is the improvement/solution?

Update AsyncStorage dependency to @react-native-async-storage/async-storage

Screenshots/Recordings

Not applicable

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 5, 2022
@gantunesr gantunesr marked this pull request as ready for review September 5, 2022 21:53
@gantunesr gantunesr requested a review from a team as a code owner September 5, 2022 21:53
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added release-5.8.0 Issue or pull request that will be included in release 5.8.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 12, 2022
@gantunesr gantunesr merged commit d8b7817 into main Sep 12, 2022
@gantunesr gantunesr deleted the dependencies/async-storage branch September 12, 2022 12:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2022
@gantunesr gantunesr added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-5.8.0 Issue or pull request that will be included in release 5.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants