Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] WebView Error Copy #4947

Merged
merged 3 commits into from
Sep 8, 2022
Merged

[IMPROVEMENT] WebView Error Copy #4947

merged 3 commits into from
Sep 8, 2022

Conversation

gantunesr
Copy link
Member

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Improved content for the error message in the app's WebView

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #4909

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.8.0 Issue or pull request that will be included in release 5.8.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Sep 6, 2022
@gantunesr gantunesr marked this pull request as ready for review September 6, 2022 18:45
@gantunesr gantunesr requested a review from a team as a code owner September 6, 2022 18:45
blackdevelopa
blackdevelopa approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andreahaku
andreahaku approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 8, 2022
@gantunesr gantunesr merged commit 439b82c into main Sep 8, 2022
@gantunesr gantunesr deleted the improvement/webview-error-copy branch September 8, 2022 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
release-5.8.0 Issue or pull request that will be included in release 5.8.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gantunesr @andreahaku @blackdevelopa