Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Typo in faucet name #4982

Merged
merged 1 commit into from
Sep 14, 2022
Merged

[FIX] Typo in faucet name #4982

merged 1 commit into from
Sep 14, 2022

Conversation

gantunesr
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Fix typo MetamMask.

Screenshots/Recordings

Not applicable

Issue

Progresses #4464

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-5.8.0 Issue or pull request that will be included in release 5.8.0 labels Sep 14, 2022
@gantunesr gantunesr marked this pull request as ready for review September 14, 2022 12:51
@gantunesr gantunesr requested a review from a team as a code owner September 14, 2022 12:51
andreahaku
andreahaku approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit 78d24c3 into main Sep 14, 2022
@gantunesr gantunesr deleted the fix/typo-faucet-name branch September 14, 2022 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2022
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-5.8.0 Issue or pull request that will be included in release 5.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gantunesr @andreahaku