You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to change the navigation bar to update when the loading starts and remove it from updating it when the loading ends.
Keeping onLoad because it seems some users still need a work around to get it work, and I have unknown data that shows me that this bug is not currently happening, and doing the patch does not seem the best option at the moment. We should check if this is still a bug on the newest versions of react native webview code.
I've clearly explained what problem this PR is solving and how it is solved.
I've linked related issues
I've included manual testing steps
I've included screenshots/recordings if applicable
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
I’ve properly set the pull request status:
In case it's not yet "ready for review", I've set it to "draft".
In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
… and do it when loading starts, also disconnect the bridge when load starts and verify immediately if the url is allowed or not, only after address updating the navigation bar if the url it is different from the previous one, removing than the update of the navigation bar only on load ends
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tommasini
added
the
needs-dev-review
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.17.0
Description
This PR aims to change the navigation bar to update when the loading starts and remove it from updating it when the loading ends.
Keeping onLoad because it seems some users still need a work around to get it work, and I have unknown data that shows me that this bug is not currently happening, and doing the patch does not seem the best option at the moment. We should check if this is still a bug on the newest versions of react native webview code.
Related issues
More details here
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist