test: 1452 refactor modal pages batch 2

[SamuelSalas]

Description

We are aiming to refactor the page objects in the modal folder so that they strictly follow the page object model pattern. This would aide in providing more readable and help standardize the way we create our tests. Because of the amount of files inside of the modal folder, the scope was divided into a batch of 4.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5480fcc) 40.90% compared to head (9b8e0ab) 40.90%.

Files	Patch %	Lines
app/components/Base/DetailsModal.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8257   +/-   ##
=======================================
  Coverage   40.90%   40.90%           
=======================================
  Files        1245     1245           
  Lines       30150    30150           
  Branches     2895     2895           
=======================================
  Hits        12333    12333           
  Misses      17114    17114           
  Partials      703      703           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cortisiko]

left some comments

[SamuelSalas]

Regression Test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/701c4020-c70a-466c-8606-3c1066259c29
Smoke Test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e18f36a-cf2e-4eeb-bd1b-82b5ee1e55fc
Appium wdio test run: https://app.bitrise.io/build/9d369fcc-d944-48c2-a00f-0352d4961708

[sonarcloud]

Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[cortisiko]

✅ ✅ ✅ ✅

[chrisleewilcox]

Regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3bedadae-3558-48ac-9f61-197febd26064

[Andepande]

LGTM