-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove friction modal for enabling the feature from settings on iOS #8552
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b55898ed-a730-47f4-84de-1fd95c5695ff |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8552 +/- ##
=========================================
+ Coverage 0 40.90% +40.90%
=========================================
Files 0 1245 +1245
Lines 0 30150 +30150
Branches 0 2895 +2895
=========================================
+ Hits 0 12333 +12333
- Misses 0 17114 +17114
- Partials 0 703 +703 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me, but I am unsure what friction modal we are fixing here
@blackdevelopa : I added screen recording to description. The friction modal that appears when blockaid is enabled has been removed in IOS. |
Description
Remove friction modal from experimental settings while enabling blockaid on iOS.
Related issues
Fixes: MetaMask/MetaMask-planning#1996
Manual testing steps
Screenshots/Recordings
Screen.Recording.2024-02-08.at.2.19.43.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist