Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: onboarding navigation #954

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Conversation

estebanmino
Copy link
Contributor

Description

In CreateWallet we had a listener to disable back button. That view also sends the user to Optin where this listener was still alive blocking any back button action, same for the webview opened from Optin.

B8rjXPwLey

When user tries to go back from optin there is an alert, we need to fix those messages before merge

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #942

Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 29, 2019
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, QA Passed 👍

@estebanmino estebanmino merged commit 1b4340d into develop Jul 29, 2019
@estebanmino estebanmino deleted the bugfix/onboarding-navigation branch August 20, 2019 18:04
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* alert going back & nav

* snaps

* alert locale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tapping "Back" on privacy policy skips onboarding screen
3 participants