Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: remove collectible when sending if not in mainnet #956

Merged
merged 4 commits into from
Jul 29, 2019

Conversation

estebanmino
Copy link
Contributor

Description

This PR adds a collectible removal method for collectibles being sent with a tx that was submitted.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #939

Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Optionally you could move it down a couple of lines it inside runAfterInteractions because it will trigger a gaba state update that's kinda heavy in the app

@estebanmino estebanmino changed the title bugfix: remove collectible when sending if not mainnet bugfix: remove collectible when sending if not in mainnet Jul 29, 2019
@estebanmino estebanmino merged commit 94a1da4 into develop Jul 29, 2019
@estebanmino
Copy link
Contributor Author

@brunobar79 good call

@estebanmino estebanmino deleted the bugfix/remove-nfts-off-mainnet branch August 20, 2019 18:04
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* rm collectible id not mainnnet

* rm after interactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collectible not removed after send
2 participants