Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse ENS caching #970

Merged
merged 6 commits into from
Aug 5, 2019
Merged

Reverse ENS caching #970

merged 6 commits into from
Aug 5, 2019

Conversation

brunobar79
Copy link
Contributor

Fixes #844

Some improvements on the EthereumAddress component and added caching, so the lookup will be done only once per session.

@brunobar79 brunobar79 changed the title Reverse ens caching Reverse ENS caching Jul 31, 2019
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brunobar79 brunobar79 merged commit 61c0c1f into develop Aug 5, 2019
@brunobar79 brunobar79 deleted the reverse-ens-caching branch August 5, 2019 17:55
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* reverse ens caching

* fix export

* clean up

* Remove logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add per session caching for ENS names
2 participants