fix: App slower when changing account and switching network

[tommasini]

Description

This PR reduces the number of api calls that happen when switching account and network, on cold and warm app starts.

• Transactions are being fetched for all the accounts instead of just the selected one, that was fixed by adding a patch to the TransactionController to only fetch per account selected (36 fetches to eth_getTransactionReceipt and counted 40+ eth_getBlockByHash, to 0 since when we are switching network on an account that doesn't have transactions)
  Screenshot of main branch with eth_getTransactionReceipt requests:
  The selected account was not orangefox.eth
  https://etherscan.io/tx/0x7ce730e2e87520e179d4e351e5cfe80565c346f9ab7688a3391306422e01f0a9

• Fixed a bug on Transaction controller where the getBlockByHash request was failing silently because it was missing one param.

• ENS fetches now only once we switch network and we change the selected account (This was looping by number of accounts and being retriggered, one 1 second, counted 15+ fetches to ens contract , now it's just fetching once it switches network and for the selected account)

• Request parallelization of token balances. (This was not optimized on number of requests but on the parallelization of the requests to have a response quicker from all of them)

• Update pooling of token balances from 10000 to 180000 miliseconds

• Added a boolean to not let the updateBalances runs if there is an update in progress. (Probably change this to use mutex when implementing on core it's a good idea)

A snapshot was updated on this PR! It seems that this snapshot was indeed wrong, and now it have the right mocked data.

Check this transaction controller core branch with the changes: mobile-patch-performance-tx-controller-13-0-0
(Once this is approved, this changes need to be merged on the patch/mobile-transaction-controller-13-0-0 branch)

Assets controller patch easy to ready, the core branch is this one: patch/mobile-assets-controllers-26-performance.
(Once this is approved, this changes need to be merged on the patch/mobile-assets-controllers-26 branch)

Next steps

• Postpone transactions requests to views that will show transactions (exg: Asset View, Activity View)

Product Changes

• ENS is now get by the selected account and not every account This was addressed in other PR already
• Transactions status is now updated only on the selected account (This still decrease the number of requests if the user has multiple accounts with multiple transactions)

Related issues

Fixes: #9250 #9249

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5833f01
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/88996dcb-9360-4380-8eb9-06a1b669121d

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5501acc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ab791257-d9c4-4bfe-9dac-edfaf38d0234

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sethkfman]

@tommasini Can you quantify the number of API calls you have reduced by this change? Is it possible that we will see improvements on UI load performance in the Wallet View?

[tommasini]

Yeah I didn't take screenshots but we can do a comparison with the main branch using flipper @sethkfman
I can also try to quantify, I need to review the scenarios. Added to the description some counting that I did throught flipper

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9645cb9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/51897b36-69b3-49ec-9def-7afabd31f3d6

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.24%. Comparing base (678c2f6) to head (8f15d00).
Report is 47 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9721      +/-   ##
==========================================
+ Coverage   46.66%   47.24%   +0.58%     
==========================================
  Files        1343     1370      +27     
  Lines       32805    33304     +499     
  Branches     3527     3586      +59     
==========================================
+ Hits        15307    15736     +429     
- Misses      16554    16607      +53     
- Partials      944      961      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8f15d00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a686d52-8505-41f7-844b-e3994aa10279

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[Cal-L]

LGTM! Are these changes also applied to core already?

[tommasini]

On the transaction controller changes, the way that transaction statuses are being fetched really change on next versions, so there was not a follow-up to core, althought this will be saved on a core branch to help next upgrades (The core branch is: patch/mobile-transaction-controller-13-0-0)

Regarding the assets controllers, this should be redirected to the core repo! I believe since now the focus is the controller upgrades, we can do it when we update assets-controllers to the latest version, begin to remove all the patch with core PRs
The work is saved on this branch: patch/mobile-assets-controllers-26