Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: transfer approval #995

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Feature: transfer approval #995

merged 2 commits into from
Aug 14, 2019

Conversation

estebanmino
Copy link
Contributor

Description

This PR adds support for ERC20 transfer transactions for approval screen to render the view with the token information. We were showing these kind of txs as ETH transactions with transfer data.
Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 13, 2019
@estebanmino estebanmino changed the title Feature: transfer approvals Feature: transfer approval Aug 13, 2019
brunobar79
brunobar79 approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

ibrahimtaveras00
ibrahimtaveras00 approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both iOS and Android, QA Passed 👍

@estebanmino estebanmino merged commit 6e3ff1e into develop Aug 14, 2019
@estebanmino estebanmino deleted the feature/transfer-approvals branch August 20, 2019 18:04
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Feature: transfer approval (#995)
867c183 
* works

* rm unused
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @brunobar79 @ibrahimtaveras00