generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks for TypeScript compliance #8
Labels
Comments
7 tasks
mcmire
changed the title
Whether the code is in Typescript or not (Needs to be coverted or not)
Add check for whether or not the library has been converted to TypeScript
Oct 12, 2023
mcmire
changed the title
Add check for whether or not the library has been converted to TypeScript
Add check for TypeScript compliance
Oct 12, 2023
mcmire
changed the title
Add check for TypeScript compliance
Add checks for TypeScript compliance
Oct 12, 2023
Note that there are other TypeScript-related considerations that we could address in this PR but do not need to:
|
Hey team! Please add your planning poker estimate with Zenhub @kanthesha @Gudahtt @mcmire @cryptodev-2s @MajorLift |
11 tasks
Merged
kanthesha
added a commit
that referenced
this issue
Mar 1, 2024
<!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes #12345 * See: #67890 --> We want to make sure that for a given project: - The project contains a tsconfig.json file, and the content of the file matches the same file in the module template - The project contains a tsconfig.build.json file, and the content of the file matches the same file in the module template - The project contains a tsup.config.ts file, and the content of the file matches the same file in the module template - The project contains @types/node, ts-node, tsup, and typescript as dev dependencies, and the versions match the same dev dependencies as in the module template - The project contains the same build and build:types package scripts as in the module template - The project's package.json has an exports field, and all of the keys in exports should be present in the project's exports field and the values should match. - The project's package.json has a main field, and its value should match the same field in the module template. - The project's package.json has a module field, and its value should match the same field in the module template. - The project's package.json has a types field, and its value should match the same field in the module template. - The project's package.json has a files field, and its value should match the same field in the module template. If project's package.json contains a lavamoat field, and that contains allowScripts, then a tsup>esbuild property should be present and should match the same one in the module template. Fixes #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We want to make sure that for a given project:
tsconfig.json
file, and the content of the file matches the same file in the module templatetsconfig.build.json
file, and the content of the file matches the same file in the module templatetsup.config.ts
file, and the content of the file matches the same file in the module template@types/node
,ts-node
,tsup
, andtypescript
as dev dependencies, and the versions match the same dev dependencies as in the module templatebuild
andbuild:types
package scripts as in the module templatepackage.json
has anexports
field, and all of the keys inexports
should be present in the project'sexports
field and the values should match.package.json
has amain
field, and its value should match the same field in the module template.package.json
has amodule
field, and its value should match the same field in the module template.package.json
has atypes
field, and its value should match the same field in the module template.package.json
has afiles
field, and its value should match the same field in the module template.package.json
contains alavamoat
field, and that containsallowScripts
, then atsup>esbuild
property should be present and should match the same one in the module template.The text was updated successfully, but these errors were encountered: