generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining code to complete MVP #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
add-remaining-code
branch
2 times, most recently
from
November 12, 2023 22:43
f204d33
to
054a651
Compare
mcmire
force-pushed
the
add-lint-project
branch
from
November 12, 2023 22:51
6daffb1
to
78c213d
Compare
mcmire
force-pushed
the
add-remaining-code
branch
from
November 12, 2023 22:52
054a651
to
87a33ed
Compare
mcmire
force-pushed
the
add-lint-project
branch
from
November 12, 2023 22:55
78c213d
to
5cedf8f
Compare
mcmire
force-pushed
the
add-remaining-code
branch
from
November 12, 2023 22:56
87a33ed
to
026153b
Compare
mcmire
force-pushed
the
add-lint-project
branch
from
November 12, 2023 23:05
5cedf8f
to
33cef68
Compare
mcmire
force-pushed
the
add-remaining-code
branch
from
November 12, 2023 23:06
026153b
to
7bfda05
Compare
mcmire
force-pushed
the
add-lint-project
branch
from
November 15, 2023 23:24
33cef68
to
09602d8
Compare
mcmire
force-pushed
the
add-remaining-code
branch
from
November 15, 2023 23:28
7bfda05
to
c28880b
Compare
mcmire
force-pushed
the
add-lint-project
branch
2 times, most recently
from
November 22, 2023 20:43
f0fd83a
to
f1483fe
Compare
All of the commits up to now have been adding code to support an MVP version of this tool. This commit ties up the MVP by adding a first rule, which merely verifies that a project has a `src/` directory, the entrypoint function to the tool, and the executable which kicks off the whole thing. This commit also adds a package script, `run-tool`, which can be used in development to quickly smoke test new changes.
mcmire
force-pushed
the
add-remaining-code
branch
from
December 1, 2023 16:44
c28880b
to
c35214c
Compare
Gudahtt
reviewed
Dec 18, 2023
Because we've set `.exitProcess(false)`, this option no longer exits automatically, so we'd have to handle it ourselves. I'm not sure anyone will miss this (yet).
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
Dec 20, 2023
Gudahtt
reviewed
Dec 20, 2023
Gudahtt
reviewed
Dec 20, 2023
Gudahtt
reviewed
Dec 20, 2023
Gudahtt
reviewed
Dec 20, 2023
Gudahtt
reviewed
Dec 20, 2023
Gudahtt
reviewed
Dec 21, 2023
Gudahtt
reviewed
Dec 21, 2023
Gudahtt
reviewed
Dec 21, 2023
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the commits up to now have been adding code to support an MVP version of this tool. This commit ties up the MVP by adding a first rule, which merely verifies that a project has a
src/
directory, the entrypoint function to the tool, and the executable which kicks off the whole thing. This commit also adds a package script,run-tool
, which can be used in development to quickly smoke test new changes.Fixes #37.