Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jest compliance #46

Merged
merged 3 commits into from
Feb 8, 2024
Merged

jest compliance #46

merged 3 commits into from
Feb 8, 2024

Conversation

kanthesha
Copy link
Contributor

@kanthesha kanthesha commented Feb 6, 2024 •
edited
Loading

We want to make sure that for a given project:

  • The project contains jest and jest-it-up as dev dependencies, and the versions match the same dev dependencies as in the module template
  • The project contains a jest.config.js, and the content of this file matches the same as in the module template
  • The project has test and test:watch package scripts, and the values of these match the same package scripts as in the module template

Fixes #10

@kanthesha kanthesha marked this pull request as ready for review February 6, 2024 19:44
@kanthesha kanthesha requested a review from a team as a code owner February 6, 2024 19:44
mcmire
mcmire reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Had some comments, mostly minor.

src/rules/package-jest-dependencies-conform.test.ts Outdated Show resolved Hide resolved
src/rules/package-jest-dependencies-conform.test.ts Outdated Show resolved Hide resolved
src/rules/package-jest-dependencies-conform.test.ts Outdated Show resolved Hide resolved
src/rules/package-jest-scripts-conform.test.ts Outdated Show resolved Hide resolved
src/rules/package-jest-scripts-conform.test.ts Outdated Show resolved Hide resolved
src/rules/package-jest-scripts-conform.test.ts Outdated Show resolved Hide resolved
src/rules/package-engines-node-field-conforms.test.ts Outdated Show resolved Hide resolved
src/rules/package-lint-dependencies-conform.test.ts Show resolved Hide resolved
src/rules/package-package-manager-field-conforms.test.ts Show resolved Hide resolved
src/rules/package-jest-scripts-conform.ts Outdated Show resolved Hide resolved
mcmire
mcmire approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice to see more progress being made here.

@kanthesha kanthesha merged commit ec7b73e into main Feb 8, 2024
22 checks passed
@kanthesha kanthesha deleted the jest-compliance branch February 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add checks for Jest compliance
2 participants
@kanthesha @mcmire