allow scripts related checks. #70
Conversation
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. What is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. What is shell access?This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code. Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced. What is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. What is a mild CVE?Contains a low severity Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known low severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
| export default buildRule({ | ||
| name: RuleName.PackageLavamoatAllowScriptsConforms, | ||
| description: | ||
| 'Does lavamoat lists `@lavamoat/preinstall-always-fail: false` in allow scripts?', |
There was a problem hiding this comment.
It just occurred to me that we include this package in the module template, but then immediately disable its functionality. That seems odd to me. I've raised a question about this in chat to see if we still need this or not.
There was a problem hiding this comment.
Yeah. similar thoughts.
There was a problem hiding this comment.
Okay, it seems that we still want this.
Maybe, however, we can reword this to sound a little more natural?
| 'Does lavamoat lists `@lavamoat/preinstall-always-fail: false` in allow scripts?', | |
| 'Are postinstall scripts disabled for `@lavamoat/preinstall-always-fail`?', |
There was a problem hiding this comment.
Updated in this commit 9a6cd36
We want to make sure that for a given project:
allow-scripts-related checks #51