-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: use forked license-checker with fixed dependencies #7
Conversation
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. What are unpublished packages?Package version was not found on the registry. It may exist on a different registry and need to be configured to pull from that registry. Packages can be removed from the registry by manually un-publishing, a security issue removal, or may simply never have been published to the registry. Reliance on these packages will cause problem when they are not found. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
a13ecf0
to
913f74b
Compare
|
913f74b
to
5f77dd0
Compare
|
@sethkfman Did you have a chance to take a look here yet? :) |
5f77dd0
to
33064c5
Compare
33064c5
to
63cc777
Compare
63cc777
to
c4321bc
Compare
c4321bc
to
1de4ad1
Compare
1de4ad1
to
3dc535f
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/license-checker@25.0.1 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves several deprecated dependencies. Using forks because upstreams are unmaintained as of 2018~2019:
https://github.com/davglass/license-checker -> https://github.com/MetaMask/license-checker
https://github.com/jslicense/spdx-compare.js -> https://github.com/MetaMask/spdx-compare.js
This repository is used for
metamask-mobile
as of MetaMask/metamask-mobile#6306Blocked by