-
Notifications
You must be signed in to change notification settings - Fork 557
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: account for caveats in permissions difference calculation (#2345)
The permission diff calculation was incorrect when considering caveats. Because of this, changes to caveats were not always correctly applied when updating a Snap. One specific instance of this was updating a Snap with: ``` 'endowment:rpc': { dapps: true }, ``` to ``` 'endowment:rpc': { allowedOrigins: ['https://metamask.io'] }, ``` This problem was fixed by introducing `permissionsDiff` which follows the implementation of `setDiff` except for the additional condition that when the permission is included in both permission sets, it is subtracted if the caveats differ.
- Loading branch information
1 parent
deae905
commit 3c11ec4
Showing
8 changed files
with
245 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"branches": 91.32, | ||
"functions": 96.58, | ||
"lines": 97.85, | ||
"statements": 97.52 | ||
"branches": 91.47, | ||
"functions": 96.61, | ||
"lines": 97.86, | ||
"statements": 97.53 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters