Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an example signature insights snap #2077

Closed
hmalik88 opened this issue Jan 8, 2024 · 3 comments · Fixed by #2079
Closed

Create an example signature insights snap #2077

hmalik88 opened this issue Jan 8, 2024 · 3 comments · Fixed by #2079
Assignees
@hmalik88

Comments

@hmalik88
Copy link
Contributor

hmalik88 commented Jan 8, 2024

Create a signature insight snap to be added to our examples package.
@hmalik88 hmalik88 self-assigned this Jan 8, 2024
This was referenced Jan 8, 2024
Merged
Merged
hmalik88 added a commit that referenced this issue Jan 10, 2024
@hmalik88
Signature insight example + type fix (#2079)
a0ac79f 
Closes #2077 

- Added a signature insight example snap
- Also sneaking in a fix for the `eth_signTypedData` signature
definition.
@ian-eulith
Copy link

I'm at the latest version of MetaMask Flask (11.7.0-flask.0) but when I try to use the signature insights feature in my snap I get:

The method "endowment:signature-insight" does not exist / is not available.

Is it actually possible to use signature insights currently?

@hmalik88
Copy link
Contributor Author

hmalik88 commented Jan 20, 2024 •
edited
Loading

I'm at the latest version of MetaMask Flask (11.7.0-flask.0) but when I try to use the signature insights feature in my snap I get:

The method "endowment:signature-insight" does not exist / is not available.

Is it actually possible to use signature insights currently?

Not yet, it hasn't shipped to Flask yet (an integration PR is open ATM). Stay tuned for the subsequent releases of Flask.

@ian-eulith
Copy link

Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmalik88 hmalik88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Signature insight example + type fix MetaMask/snaps
2 participants
@hmalik88 @ian-eulith