Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom UI positioning system #2278

Closed
ziedbrini opened this issue Mar 14, 2024 · 1 comment · Fixed by MetaMask/metamask-extension#24827
Closed

Custom UI positioning system #2278

ziedbrini opened this issue Mar 14, 2024 · 1 comment · Fixed by MetaMask/metamask-extension#24827
Assignees
@FrederikBolding @eriknson
Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0

Comments

@ziedbrini
Copy link

ziedbrini commented Mar 14, 2024 •
edited by eriknson
Loading

No description provided.

@eriknson eriknson changed the title Implement a positioning system Custom UI positioning system Apr 29, 2024
@eriknson
Copy link
Member

We're leaning towards adding the options direction="horizontal" or direction="vertical" to the upcoming Box component.

<Box> will have no margins or padding and an internal gap that is fixed at 8px

@FrederikBolding FrederikBolding self-assigned this May 21, 2024
@FrederikBolding FrederikBolding mentioned this issue May 22, 2024
Merged
FrederikBolding added a commit that referenced this issue May 22, 2024
@FrederikBolding @metamaskbot
feat: add box positioning props (#2422)
f062abc 
Adds support for `direction` and `alignment` props on `Box`. This allows
for more customization when positioning elements in Snaps UI.

Technically `direction` maps to `flexDirection` and `alignment` to
`justifyContent`.

Progresses #2278

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
@FrederikBolding FrederikBolding mentioned this issue May 28, 2024
Merged
FrederikBolding added a commit to MetaMask/metamask-extension that referenced this issue May 29, 2024
@FrederikBolding
chore: bump Snaps packages (#24827)
038dbbb 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Bump snaps packages to latest and handle breaking changes.

Summary of changes in the snaps deps:
- Add `Value` component
- Add `Dropdown` component
- Add positioning props to `Box`
- Allow `Button` within `Input`
- Add `context` field to `snap_createInterface`
- Add feature flag to disable platform

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24827?quickstart=1)

## **Related issues**

Closes MetaMask/MetaMask-planning#1686
Closes MetaMask/snaps#2278
Closes MetaMask/MetaMask-planning#1575
Closes MetaMask/snaps#2402
Closes MetaMask/snaps#2299

## Manual testing steps
1. Install and use the interactive UI Snap from
https://metamask.github.io/snaps/test-snaps/latest/ - including
transaction insights
2. See that the new components work
3. Disable "basic functionality"
4. See that Snaps no longer works
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 29, 2024
benefacto pushed a commit to zenchain-protocol/zazen that referenced this issue Jul 3, 2024
@FrederikBolding @metamaskbot
feat: add box positioning props (#2422)
89dca56 
Adds support for `direction` and `alignment` props on `Box`. This allows
for more customization when positioning elements in Snaps UI.

Technically `direction` maps to `flexDirection` and `alignment` to
`justifyContent`.

Progresses MetaMask/snaps#2278

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederikBolding FrederikBolding

@eriknson eriknson

Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump Snaps packages MetaMask/metamask-extension
4 participants
@FrederikBolding @eriknson @metamaskbot @ziedbrini