Add image fetching utility functions #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/image-utils
branch
from
5c32270 to
327fcd5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1995 +/- ##
==========================================
+ Coverage 96.06% 96.08% +0.01%
==========================================
Files 266 267 +1
Lines 6202 6227 +25
Branches 999 1005 +6
==========================================
+ Hits 5958 5983 +25
Misses 244 244 ☔ View full report in Codecov by Sentry. |
hmalik88
reviewed
Nov 29, 2023
|
@metamaskbot update-pr |
Mrtenz
force-pushed
the
mrtenz/image-utils
branch
from
35c2c5b to
5c0b518
Compare
hmalik88
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new functions which can be used for fetching images (PNG, JPG) in a Snap:
getImageData: Returns the raw image data string, which can be used as ahrefin an SVG image.getImageComponent: Returns an image component which can be used in Snaps UI.Closes MetaMask/MetaMask-planning#1573.