Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial permissions types #2111

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Fix initial permissions types #2111

merged 7 commits into from
Jan 19, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jan 19, 2024

  • snap_confirm was removed a long time ago.
  • Certain permissions were missing.
  • Everything is now wrapped in Partial.

@Mrtenz Mrtenz marked this pull request as ready for review January 19, 2024 10:39
@Mrtenz Mrtenz requested a review from a team as a code owner January 19, 2024 10:39
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (479654c) 96.65% compared to head (618d058) 96.65%.

❗ Current head 618d058 differs from pull request most recent head e941c27. Consider uploading reports for the commit e941c27 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2111   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files         312      312           
  Lines        7032     7032           
  Branches     1103     1103           
=======================================
  Hits         6797     6797           
  Misses        235      235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz changed the title Fix initial permissions type in snaps-sdk Fix initial permissions types Jan 19, 2024
@Mrtenz Mrtenz merged commit 51eab98 into main Jan 19, 2024
142 checks passed
@Mrtenz Mrtenz deleted the mrtenz/sdk-permissions branch January 19, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants