Fix minimum version for CLIs #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
==========================================
- Coverage 96.60% 96.60% -0.01%
==========================================
Files 337 337
Lines 7629 7625 -4
Branches 1186 1184 -2
==========================================
- Hits 7370 7366 -4
Misses 259 259 ☔ View full report in Codecov by Sentry. |
Mrtenz
reviewed
Mar 20, 2024
Mrtenz
previously approved these changes
Mar 20, 2024
Mrtenz
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the checks for minimum versions in the CLI.
The minimum Node.js version we support is
18.16, this was not reflected properly in our CLIs. After this PR the CLIs will check the minimum version themselves by looking in the package.json instead of relying on a constant.