feat: add context field to snap_createInterface
#2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
changed the title
context field to createInterfacecontext field to createInterface
FrederikBolding
force-pushed
the
fb/add-interface-context
branch
2 times, most recently
from
196e10d to
dd06df7
Compare
FrederikBolding
force-pushed
the
fb/add-interface-context
branch
from
dd06df7 to
5740a9a
Compare
|
@metamaskbot update-pr |
FrederikBolding
changed the title
context field to createInterfacecontext field to snap_createInterface
GuillaumeRx
approved these changes
May 23, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional
contextparameter tosnap_createInterface, thiscontextis stored in state and exposed toonUserInput, allowing for storage of small amounts of data (1 MB to start) for use in UIs without usingmanageState.In the future we may consider allowing the Snap to modify this data using
snap_updateInterface, but this implementation doesn't do that.Progresses #2402