Support conditional children in most JSX components #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot update-pr |
| @@ -161,7 +161,7 @@ export const OptionStruct: Describe<OptionElement> = element('Option', { | |||
| export const DropdownStruct: Describe<DropdownElement> = element('Dropdown', { | |||
| name: string(), | |||
| value: optional(string()), | |||
| children: maybeArray(OptionStruct), | |||
| children: maybeArray(nullUnion([OptionStruct, boolean()])), | |||
There was a problem hiding this comment.
Realizing that this means that null isn't allowed in Dropdowns currently.
Would it be easier to have a jsxChildren struct that takes a list of structs and combines that with boolean(), null etc?
There was a problem hiding this comment.
Sure, that does sound easier.
| @@ -6,7 +6,7 @@ import type { StandardFormattingElement } from './formatting'; | |||
| * The children of the {@link Link} component. | |||
| */ | |||
| export type LinkChildren = MaybeArray< | |||
There was a problem hiding this comment.
Same question with regards to types, would it be easier to have a shared type that adds boolean | null and whatever else
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2506 +/- ##
=======================================
Coverage 94.40% 94.40%
=======================================
Files 442 442
Lines 9125 9127 +2
Branches 1411 1412 +1
=======================================
+ Hits 8614 8616 +2
Misses 511 511 ☔ View full report in Codecov by Sentry. |
Mrtenz
force-pushed
the
mrtenz/conditional-children
branch
from
ebed3d9 to
4fff8c8
Compare
FrederikBolding
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for conditional children in most JSX components. The exceptions are
Field,Row, and other components which don't have children in the first place. For example, the following is now possible:To support this, I've added
booleanas valid prop for the JSX components. ThegetJsxChildrenfunction filters out any falsy or literaltruevalues.I've also added a small contributing guide for conventions around JSX components, including the support for conditional children.
Closes #2505.