Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 58.0.0 #2595

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Release 58.0.0 #2595

merged 5 commits into from
Jul 23, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Jul 22, 2024

Explanation

This is the release candidate for v58.0.0.

  • @metamask/snaps-controllers@9.3.1 (patch)
  • @metamask/snaps-execution-environments@6.6.2 (patch)
  • @metamask/snaps-rpc-methods@10.0.1 (patch)
  • @metamask/snaps-utils@7.8.1 (patch)

Notes

  • Removes @metamask/utils yarn resolution to 9.1.0.
  • Bumps @metamask/eth-json-rpc-middleware from ^12.1.2 to ^13.0.0 in @metamask/snaps-{jest,simulator}.
  • The permission-controller major version bump doesn't affect the snaps monorepo as a breaking change, as the updated enums CaveatMutatorOperations, MethodNames are not used in any snaps package.

Blockers

  • Blocked by Fix regressions introduced by @metamask/providers@17.1.1 #2579: With yarn resolution for @metamask/utils removed, @metamask/snaps-execution-environments experiences a build error due to version mismatch between @metamask/providers (@metamask/utils@8.5.0) and @metamask/utils@9.1.0.

    • Resolved with @metamask/providers@17.1.2
  • With @metamask/providers@17.0.0

 YN0000: [@metamask/snaps-execution-environments]: src/common/BaseSnapExecutor.ts(373,23): error TS2322: Type 'import("/Users/majorlift/Code/metamask/snaps/node_modules/@metamask/json-rpc-engine/dist/types/JsonRpcEngine").JsonRpcMiddleware<import("/Users/majorlift/Code/metamask/snaps/node_modules/@metamask/utils/dist/json").JsonRpcParams, import("/Users/majorlift/Code/metamask/snaps/node_modules/@metamask/utils/dist/json").J...' is not assignable to type 'import("/Users/majorlift/Code/metamask/snaps/node_modules/@metamask/providers/node_modules/@metamask/json-rpc-engine/dist/types/JsonRpcEngine").JsonRpcMiddleware<import("/Users/majorlift/Code/metamask/snaps/node_modules/@metamask/providers/node_modules/@metamask/utils/dist/json").JsonRpcParams, import("/Users/majorl...'.
 YN0000: [@metamask/snaps-execution-environments]:   Types of parameters 'req' and 'req' are incompatible.
 YN0000: [@metamask/snaps-execution-environments]:     Type 'import("/Users/majorlift/Code/metamask/snaps/node_modules/@metamask/providers/node_modules/@metamask/utils/dist/json").JsonRpcRequest<import("/Users/majorlift/Code/metamask/snaps/node_modules/@metamask/providers/node_modules/@metamask/utils/dist/json").JsonRpcParams>' is not assignable to type 'import("/Users/majorlift/Code/metamask/snaps/node_modules/@metamask/utils/dist/json").JsonRpcRequest<import("/Users/majorlift/Code/metamask/snaps/node_modules/@metamask/utils/dist/json").JsonRpcParams>'.
➤ YN0000: [@metamask/snaps-execution-environments]:       Type 'JsonRpcRequest<JsonRpcParams>' is not assignable to type '{ params?: ((Record<string, Json> | Json[]) & ExactOptionalGuard) | undefined; id: string | number | null; method: string; jsonrpc: "2.0"; }'.
➤ YN0000: [@metamask/snaps-execution-environments]:         Types of property 'params' are incompatible.
➤ YN0000: [@metamask/snaps-execution-environments]:           Type '(((Record<string, Json> | Json[]) & ExactOptionalGuard) & JsonRpcParams) | undefined' is not assignable to type '((Record<string, Json> | Json[]) & ExactOptionalGuard) | undefined'.
➤ YN0000: [@metamask/snaps-execution-environments]:             Type 'Record<string, Json> & ExactOptionalGuard' is not assignable to type '((Record<string, Json> | Json[]) & ExactOptionalGuard) | undefined'.
➤ YN0000: [@metamask/snaps-execution-environments]:               Type 'Record<string, Json> & ExactOptionalGuard' is not assignable to type 'Json[] & ExactOptionalGuard'.
➤ YN0000: [@metamask/snaps-execution-environments]:                 Type 'Record<string, Json> & ExactOptionalGua
  • With yarn resolution entry "@metamask/snaps-execution-environments/@metamask/providers": "17.1.1"
 YN0000: [@metamask/snaps-execution-environments]: node_modules/@metamask/providers/dist/EIP6963.d.cts(11,9): error TS2717: Subsequent property declarations must have the same type.  Property '[EIP6963EventNames.Request]' must be of type 'EIP6963RequestProviderEvent', but here has type 'EIP6963RequestProviderEvent'.
 YN0000: [@metamask/snaps-execution-environments]: node_modules/@metamask/providers/dist/EIP6963.d.cts(12,9): error TS2717: Subsequent property declarations must have the same type.  Property '[EIP6963EventNames.Announce]' must be of type 'EIP6963AnnounceProviderEvent', but here has type 'EIP6963AnnounceProviderEvent'.

@MajorLift MajorLift self-assigned this Jul 22, 2024
@MajorLift MajorLift force-pushed the release/58.0.0 branch 3 times, most recently from 67c94e4 to 094be8c Compare July 22, 2024 18:10
@MajorLift MajorLift marked this pull request as ready for review July 22, 2024 18:17
@MajorLift MajorLift requested a review from a team as a code owner July 22, 2024 18:17
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.00%. Comparing base (223878c) to head (0d72427).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2595   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files         459      459           
  Lines        9650     9650           
  Branches     1482     1482           
=======================================
  Hits         9071     9071           
  Misses        579      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Jul 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-json-rpc-middleware@13.0.0 network +10 1.02 MB metamaskbot
npm/@noble/curves@1.1.0 None 0 1.3 MB paulmillr
npm/@scure/base@1.1.3 None 0 77.8 kB paulmillr
npm/@scure/bip32@1.3.1 None 0 55.7 kB paulmillr
npm/@scure/bip39@1.2.1 None 0 357 kB paulmillr
npm/@types/debug@4.1.7 None 0 7.22 kB types
npm/@types/ms@0.7.31 None 0 2.88 kB types
npm/ethereum-cryptography@2.1.2 None 0 84.3 kB paulmillr

🚮 Removed packages: npm/@metamask/eth-json-rpc-middleware@12.1.2, npm/@scure/base@1.1.7

View full report↗︎

Copy link

socket-security bot commented Jul 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/eth-block-tracker@10.1.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@MajorLift
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/eth-block-tracker@10.1.0
MetaMask package

@MajorLift MajorLift merged commit cede015 into main Jul 23, 2024
156 checks passed
@MajorLift MajorLift deleted the release/58.0.0 branch July 23, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants