Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icon component #2638

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Added icon component #2638

merged 4 commits into from
Aug 16, 2024

Conversation

ritave
Copy link
Contributor

@ritave ritave commented Aug 15, 2024

Part of https://github.com/MetaMask/MetaMask-planning/issues/1615.

This adds an icon component on the Snaps SDK side of things, awaiting implementation in metamask-extension.

It's usable in Box, Tooltip and Text

@ritave ritave requested a review from a team as a code owner August 15, 2024 13:09
Mrtenz
Mrtenz previously approved these changes Aug 15, 2024
@eriknson
Copy link
Member

eriknson commented Aug 15, 2024

Let's just expose md (20px) size, and default, primary, and muted colors to begin with

@eriknson
Copy link
Member

We'll make these—and any other static component—hoverable & clickable using some sort of <onClick> wrapper soon

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.27%. Comparing base (6a8b17b) to head (5eb2bc9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2638      +/-   ##
==========================================
+ Coverage   94.18%   94.27%   +0.09%     
==========================================
  Files         477      478       +1     
  Lines        9834     9999     +165     
  Branches     1498     1499       +1     
==========================================
+ Hits         9262     9427     +165     
  Misses        572      572              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
@ritave ritave merged commit 6b4e300 into main Aug 16, 2024
154 checks passed
@ritave ritave deleted the ritave/icon branch August 16, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants