-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for metamask:
schemed URLs
#2719
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2719 +/- ##
==========================================
+ Coverage 94.35% 94.37% +0.01%
==========================================
Files 476 477 +1
Lines 10139 10183 +44
Branches 1542 1555 +13
==========================================
+ Hits 9567 9610 +43
- Misses 572 573 +1 ☔ View full report in Codecov by Sentry. |
What happens if there's a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this as this requires further discussion.
Button
componentmetamask:
schemed URLs
Validation logic has been updated to allow for an
Icon
to also be included as aLink
child. A new URL scheme is also introducedmetamask:
(see SIP-22), this scheme will allow a snap to navigate to the extension and other snap pages through ametamask:
schemed URL.