Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog validation scripts to match MetaMask/core #2741

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Sep 19, 2024

In an effort to standardise the repository more, I'm working on matching different parts of our repository configuration to match MetaMask/core. In this PR I've updated our changelog validation scripts, and formatted the changelogs using Prettier.

This also solves a long standing issue where we would have to format changelogs each time after creating a new release PR.

There are a lot of changes in this PR, but the notable changes are in the package.json files:

  • lint:changelog is now changelog:validate.
  • changelog:validate now accepts a --fix parameter which will be properly forwarded to the validation script.
  • There is a new changelog:update script.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (e3cbd4a) to head (9f49669).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2741   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files         476      476           
  Lines       10137    10137           
  Branches     1542     1542           
=======================================
  Hits         9565     9565           
  Misses        572      572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz marked this pull request as ready for review September 19, 2024 13:34
@Mrtenz Mrtenz requested a review from a team as a code owner September 19, 2024 13:34
@Mrtenz Mrtenz merged commit 9c208ac into main Sep 19, 2024
162 checks passed
@Mrtenz Mrtenz deleted the mrtenz/update-changelog-validation-scripts branch September 19, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants