fix: Add missing dependency on execution environments to snaps-simulation
#2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
approved these changes
Oct 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2791 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 483 483
Lines 10297 10297
Branches 1568 1568
=======================================
Hits 9724 9724
Misses 573 573 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving the simulation logic to
snaps-simulation, we forgot to addsnaps-execution-environmentsas a direct dependency. This causes errors at runtime when trying to install the latest version ofsnaps-jest.snaps-execution-environmentsis an optional peer dependency ofsnaps-controllers. But is not optional forsnaps-simulationas it leverages the Node execution environments.