Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property and hook for specifying custom cryptography functions #2909

Merged
merged 13 commits into from
Nov 28, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 27, 2024

key-tree now allows specifying custom functions to use for cryptography. To support this in Snaps, I've added a new hook getClientCryptography to the SnapController and entropy-related JSON-RPC methods. This hook should return an object containing the functions to use (or just an empty object to use the defaults).

Copy link

socket-security bot commented Nov 27, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/key-tree@10.0.1 Transitive: environment +5 4.43 MB metamaskbot

🚮 Removed packages: npm/@metamask/key-tree@9.1.2

View full report↗︎

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (cbe55de) to head (fe868ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2909   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         487      487           
  Lines       10427    10429    +2     
  Branches     1598     1598           
=======================================
+ Hits         9852     9854    +2     
  Misses        575      575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz marked this pull request as ready for review November 28, 2024 09:49
@Mrtenz Mrtenz requested a review from a team as a code owner November 28, 2024 09:49
@Mrtenz Mrtenz changed the title Add getClientCryptography hook to SnapController and related JSON-RPC methods Add property and hook for specifying custom cryptography functions Nov 28, 2024
@Mrtenz Mrtenz merged commit 03cd5d6 into main Nov 28, 2024
166 checks passed
@Mrtenz Mrtenz deleted the mrtenz/client-cryptography branch November 28, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants