Add requireScroll prop to Footer component
#3031
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3031 +/- ##
=======================================
Coverage 94.80% 94.80%
=======================================
Files 503 503
Lines 10996 10996
Branches 1685 1685
=======================================
Hits 10425 10425
Misses 571 571 ☔ View full report in Codecov by Sentry. |
hmalik88
changed the title
requireCompleteView prop to Footer componentrequireScroll prop to Footer component
Mrtenz
requested changes
Jan 23, 2025
GuillaumeRx
reviewed
Jan 23, 2025
GuillaumeRx
previously approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new prop to require that snap ui content be viewed entirely before enabling the footer button(s).
Note: This is the snaps side code for #3021, a follow up PR to integrate in the extension will be opened.