Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add get allowance support for ERC20 tokens #312

Merged
merged 4 commits into from
Apr 8, 2024
Merged

feat: add get allowance support for ERC20 tokens #312

merged 4 commits into from
Apr 8, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Apr 8, 2024 •
edited
Loading

Description

This PR adds support for querying the allowance(address owner, address spender) → uint256 function for ERC20 tokens.
This will enable testing more effectively the Approve and Increase Allowance functionalities.

Screenshots

Screenshot from 2024-04-08 12-44-11

get-allowance-test-dapp2.mp4

Manual Testing Steps

  1. Deploy an ERC20 token contract
  2. Add owner and spender addresses
  3. Click get allowance
  4. Perform an approve or increase allowance to the same spender and owner
  5. Click get allowance
  6. See how the amount changed

@seaona seaona marked this pull request as ready for review April 8, 2024 11:19
@seaona seaona merged commit 0257786 into main Apr 8, 2024
7 checks passed
@seaona seaona deleted the get-allowance branch April 8, 2024 15:58
@sleepytanya sleepytanya mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digiwand digiwand digiwand approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seaona @digiwand @blackdevelopa